Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

[stable/postgresql] Fix upgradability of metrics deployment. #9119

Merged
merged 1 commit into from
Nov 8, 2018
Merged

[stable/postgresql] Fix upgradability of metrics deployment. #9119

merged 1 commit into from
Nov 8, 2018

Conversation

desaintmartin
Copy link
Collaborator

See #7726.
Current state prevents to upgrade the whole chart if metrics are used.

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md

@desaintmartin
[stable/postgresql] Fix upgradability of metrics deployment.
ac01887 
See #7726.

Signed-off-by: Cédric de Saint Martin <cdesaintmartin@wiremind.fr>
@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 8, 2018
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 8, 2018
@k8s-ci-robot
Copy link
Contributor

Hi @desaintmartin. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@davidkarlsen
Copy link
Member

/ok-to-test
/lgtm
/assign

@k8s-ci-robot k8s-ci-robot added ok-to-test lgtm Indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 8, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidkarlsen, desaintmartin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 8, 2018
@k8s-ci-robot k8s-ci-robot merged commit 27e0137 into helm:master Nov 8, 2018
@desaintmartin desaintmartin deleted the postgresql-st-upgrade branch November 8, 2018 19:26
wgiddens pushed a commit to wgiddens/charts that referenced this pull request Jan 18, 2019
@desaintmartin @wgiddens
[stable/postgresql] Fix upgradability of metrics deployment. (helm#9119)
92e68ae 
See helm#7726.

Signed-off-by: Cédric de Saint Martin <cdesaintmartin@wiremind.fr>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@carrodher carrodher Awaiting requested review from carrodher

@prydonius prydonius Awaiting requested review from prydonius

Assignees

@davidkarlsen davidkarlsen

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@desaintmartin @k8s-ci-robot @davidkarlsen @helm-bot